diff --git a/programs/Hadrons/Application.cc b/programs/Hadrons/Application.cc index c21dba5d..21184667 100644 --- a/programs/Hadrons/Application.cc +++ b/programs/Hadrons/Application.cc @@ -20,7 +20,6 @@ #include #include -using namespace std; using namespace Grid; using namespace Hadrons; @@ -34,9 +33,9 @@ Application::Application(int argc, char *argv[]) { if (argc < 2) { - cerr << "usage: " << argv[0] << " [Grid options]"; - cerr << endl; - exit(EXIT_FAILURE); + std::cerr << "usage: " << argv[0] << " [Grid options]"; + std::cerr << std::endl; + std::exit(EXIT_FAILURE); } parameterFileName_ = argv[1]; Grid_init(&argc, &argv); @@ -44,19 +43,19 @@ Application::Application(int argc, char *argv[]) HadronsLogWarning.Active(GridLogWarning.isActive()); HadronsLogMessage.Active(GridLogMessage.isActive()); HadronsLogDebug.Active(GridLogDebug.isActive()); - LOG(Message) << "Grid initialized" << endl; - LOG(Message) << "Modules available:" << endl; + LOG(Message) << "Grid initialized" << std::endl; + LOG(Message) << "Modules available:" << std::endl; auto list = modFactory_.getModuleList(); for (auto &m: list) { - LOG(Message) << " " << m << endl; + LOG(Message) << " " << m << std::endl; } } // destructor ////////////////////////////////////////////////////////////////// Application::~Application(void) { - LOG(Message) << "Grid is finalizing now" << endl; + LOG(Message) << "Grid is finalizing now" << std::endl; Grid_finalize(); } @@ -82,7 +81,7 @@ void Application::parseParameterFile(void) XmlReader reader(parameterFileName_); ModuleId id; - LOG(Message) << "Reading '" << parameterFileName_ << "'..." << endl; + LOG(Message) << "Reading '" << parameterFileName_ << "'..." << std::endl; read(reader, "parameters", par_); push(reader, "modules"); push(reader, "module"); @@ -91,7 +90,7 @@ void Application::parseParameterFile(void) read(reader, "id", id); module_[id.name] = modFactory_.create(id.type, id.name); module_[id.name]->parseParameters(reader, "options"); - vector output = module_[id.name]->getOutput(); + std::vector output = module_[id.name]->getOutput(); for (auto &n: output) { associatedModule_[n] = id.name; @@ -104,21 +103,21 @@ void Application::parseParameterFile(void) // schedule computation //////////////////////////////////////////////////////// void Application::schedule(void) { - Graph moduleGraph; + Graph moduleGraph; - LOG(Message) << "Scheduling computation..." << endl; + LOG(Message) << "Scheduling computation..." << std::endl; // create dependency graph for (auto &m: module_) { - vector input = m.second->getInput(); + std::vector input = m.second->getInput(); for (auto &n: input) { try { moduleGraph.addEdge(associatedModule_.at(n), m.first); } - catch (out_of_range &) + catch (std::out_of_range &) { HADRON_ERROR("unknown object '" + n + "'"); } @@ -126,21 +125,21 @@ void Application::schedule(void) } // topological sort - map> m; - unsigned int k = 0; + std::map> m; + unsigned int k = 0; - vector> con = moduleGraph.getConnectedComponents(); - LOG(Message) << "Program:" << endl; + std::vector> con = moduleGraph.getConnectedComponents(); + LOG(Message) << "Program:" << std::endl; for (unsigned int i = 0; i < con.size(); ++i) { - vector> t = con[i].allTopoSort(); + std::vector> t = con[i].allTopoSort(); m = makeDependencyMatrix(t); for (unsigned int j = 0; j < t[0].size(); ++j) { program_.push_back(t[0][j]); - LOG(Message) << setw(4) << right << k << ": " - << program_[k] << endl; + LOG(Message) << std::setw(4) << std::right << k << ": " + << program_[k] << std::endl; k++; } } @@ -153,7 +152,8 @@ void Application::configLoop(void) for (unsigned int t = range.start; t < range.end; t += range.step) { - LOG(Message) << "Starting measurement for trajectory " << t << endl; + LOG(Message) << "Starting measurement for trajectory " << t + << std::endl; execute(); } } @@ -163,7 +163,7 @@ void Application::execute(void) for (unsigned int i = 0; i < program_.size(); ++i) { LOG(Message) << "Measurement step (" << i+1 << "/" << program_.size() - << ")" << endl; + << ")" << std::endl; (*module_[program_[i]])(env_); } } diff --git a/programs/Hadrons/CMeson.cc b/programs/Hadrons/CMeson.cc index d9fe3547..32febc13 100644 --- a/programs/Hadrons/CMeson.cc +++ b/programs/Hadrons/CMeson.cc @@ -19,7 +19,6 @@ #include -using namespace std; using namespace Grid; using namespace Hadrons; @@ -27,7 +26,7 @@ using namespace Hadrons; * CMeson implementation * ******************************************************************************/ // constructor ///////////////////////////////////////////////////////////////// -CMeson::CMeson(const string &name) +CMeson::CMeson(const std::string &name) : Module(name) {} @@ -38,16 +37,16 @@ void CMeson::parseParameters(XmlReader &reader, const std::string &name) } // dependency relation ///////////////////////////////////////////////////////// -vector CMeson::getInput(void) +std::vector CMeson::getInput(void) { - vector input = {par_.q1, par_.q2}; + std::vector input = {par_.q1, par_.q2}; return input; } -vector CMeson::getOutput(void) +std::vector CMeson::getOutput(void) { - vector output = {getName()}; + std::vector output = {getName()}; return output; } @@ -61,5 +60,6 @@ double CMeson::nCreatedProp(void) // execution /////////////////////////////////////////////////////////////////// void CMeson::operator()(Environment &env) { - LOG(Message) << "computing meson contraction '" << getName() << "'" << endl; + LOG(Message) << "computing meson contraction '" << getName() << "'" + << std::endl; } diff --git a/programs/Hadrons/Environment.cc b/programs/Hadrons/Environment.cc index 66dd540e..391f0c04 100644 --- a/programs/Hadrons/Environment.cc +++ b/programs/Hadrons/Environment.cc @@ -19,7 +19,6 @@ #include -using namespace std; using namespace Grid; using namespace Hadrons; diff --git a/programs/Hadrons/Global.cc b/programs/Hadrons/Global.cc index aea2f7c1..a560d71f 100644 --- a/programs/Hadrons/Global.cc +++ b/programs/Hadrons/Global.cc @@ -19,7 +19,6 @@ #include -using namespace std; using namespace Grid; using namespace Hadrons; diff --git a/programs/Hadrons/Hadrons.cc b/programs/Hadrons/Hadrons.cc index 6788c237..00da4a76 100644 --- a/programs/Hadrons/Hadrons.cc +++ b/programs/Hadrons/Hadrons.cc @@ -19,7 +19,6 @@ #include -using namespace std; using namespace Hadrons; int main(int argc, char *argv[]) diff --git a/programs/Hadrons/MQuark.cc b/programs/Hadrons/MQuark.cc index 82c46c52..2cc27311 100644 --- a/programs/Hadrons/MQuark.cc +++ b/programs/Hadrons/MQuark.cc @@ -19,7 +19,6 @@ #include -using namespace std; using namespace Grid; using namespace Hadrons; @@ -38,14 +37,14 @@ void MQuark::parseParameters(XmlReader &reader, const std::string &name) } // dependency relation -vector MQuark::getInput(void) +std::vector MQuark::getInput(void) { - return vector(); + return std::vector(); } -vector MQuark::getOutput(void) +std::vector MQuark::getOutput(void) { - vector out = {getName(), getName() + "_5d"}; + std::vector out = {getName(), getName() + "_5d"}; return out; } @@ -59,5 +58,6 @@ double MQuark::nCreatedProp(void) // execution void MQuark::operator()(Environment &env) { - LOG(Message) << "computing quark propagator '" << getName() << "'" << endl; + LOG(Message) << "computing quark propagator '" << getName() << "'" + << std::endl; } diff --git a/programs/Hadrons/Module.cc b/programs/Hadrons/Module.cc index be689867..5267449c 100644 --- a/programs/Hadrons/Module.cc +++ b/programs/Hadrons/Module.cc @@ -19,7 +19,6 @@ #include -using namespace std; using namespace Grid; using namespace Hadrons; @@ -27,12 +26,12 @@ using namespace Hadrons; * Module implementation * ******************************************************************************/ // constructor ///////////////////////////////////////////////////////////////// -Module::Module(const string &name) +Module::Module(const std::string &name) : name_(name) {} // access ////////////////////////////////////////////////////////////////////// -string Module::getName(void) const +std::string Module::getName(void) const { return name_; } diff --git a/programs/Hadrons/ModuleFactory.cc b/programs/Hadrons/ModuleFactory.cc index 2a87da3a..084d272d 100644 --- a/programs/Hadrons/ModuleFactory.cc +++ b/programs/Hadrons/ModuleFactory.cc @@ -19,7 +19,6 @@ #include -using namespace std; using namespace Grid; using namespace Hadrons; @@ -52,8 +51,8 @@ std::vector ModuleFactory::getModuleList(void) const } // factory ///////////////////////////////////////////////////////////////////// -unique_ptr ModuleFactory::create(const string &type, - const string &name) const +std::unique_ptr ModuleFactory::create(const std::string &type, + const std::string &name) const { FactoryFunc func; @@ -61,7 +60,7 @@ unique_ptr ModuleFactory::create(const string &type, { func = factory_.at(type); } - catch (out_of_range) + catch (std::out_of_range) { HADRON_ERROR("module type '" + type + "' unknown"); }