macOS CI update

.github/workflows/build-macos.yml

@@ -5,7 +5,7 @@ on: [push, workflow_dispatch]
 jobs:
   build:
 
-    runs-on: macos-11
+    runs-on: macos-15
 
     steps:
     - name: Checkout

.github/workflows/build-ubuntu.yml

@@ -5,7 +5,7 @@ on: [push]
 jobs:
   build:
 
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
     - name: Checkout

CMakeLists.txt

@@ -1,5 +1,5 @@
 # package config
-cmake_minimum_required(VERSION 3.11.0)
+cmake_minimum_required(VERSION 3.24.0)
 project(
   LatAnalyze
   VERSION 3.6
@@ -41,18 +41,17 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}")
 
 # fetch and create symbolic link to Eigen headers
-set(FETCHCONTENT_BASE_DIR ${CMAKE_BINARY_DIR}/deps)
+set(EIGEN_URL "https://gitlab.com/libeigen/eigen/-/archive/3.4.0/eigen-3.4.0.tar.gz")
-FetchContent_Declare(
+set(EIGEN_TGZ "${CMAKE_BINARY_DIR}/eigen-3.4.0.tar.gz")
-  Eigen3
+set(EIGEN_DIR "${CMAKE_BINARY_DIR}/deps/eigen-src")
-  GIT_REPOSITORY https://gitlab.com/libeigen/eigen.git
+if(NOT EXISTS "${EIGEN_DIR}/Eigen/Dense")
-  GIT_TAG 3.4.0)
+    file(DOWNLOAD "${EIGEN_URL}" "${EIGEN_TGZ}" SHOW_PROGRESS)
-FetchContent_GetProperties(Eigen3)
+    file(ARCHIVE_EXTRACT INPUT "${EIGEN_TGZ}" DESTINATION "${CMAKE_BINARY_DIR}/deps")
-if(NOT eigen3_POPULATED)
+    file(GLOB EIGEN_EXTRACTED_DIR "${CMAKE_BINARY_DIR}/deps/eigen-*")
-  FetchContent_Populate(Eigen3)
+    file(RENAME "${EIGEN_EXTRACTED_DIR}" "${EIGEN_DIR}")
-  message(STATUS "Eigen3 fetched")
+    message(STATUS "Eigen3 fetched")
 endif()
-file(CREATE_LINK ${eigen3_SOURCE_DIR}/Eigen
+file(CREATE_LINK ${EIGEN_DIR}/Eigen ${CMAKE_SOURCE_DIR}/lib/LatAnalyze/Eigen SYMBOLIC)
-     ${CMAKE_SOURCE_DIR}/lib/LatAnalyze/Eigen SYMBOLIC)
 
 # dependencies
 find_package(Threads REQUIRED)

ci-scripts/install-gsl.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-name='gsl-2.6'
+name='gsl-2.8'
 
 if (($# != 2)); then
   echo "usage: $(basename "$0") <prefix> <ntasks>" 1>&2
@@ -15,7 +15,7 @@ mkdir -p "${prefix}"
 cd "${prefix}"
 prefix=$(pwd -P)
 cd "${init_dir}/local/build"
-wget http://ftpmirror.gnu.org/gsl/${name}.tar.gz
+wget https://mirror.ibcp.fr/pub/gnu/gsl/${name}.tar.gz
 tar -xzvf ${name}.tar.gz
 mkdir -p ${name}/build
 cd ${name}/build

lib/CMakeLists.txt

@@ -88,10 +88,12 @@ install(
   FILE LatAnalyzeTargets.cmake
   NAMESPACE LatAnalyze::
   DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/LatAnalyze)
+set(INCLUDE_INSTALL_DIR "${CMAKE_INSTALL_INCLUDEDIR}")
 configure_package_config_file(
   ${CMAKE_CURRENT_SOURCE_DIR}/Config.cmake.in
   "${CMAKE_CURRENT_BINARY_DIR}/LatAnalyzeConfig.cmake"
-  INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/LatAnalyze)
+  INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/LatAnalyze
+  PATH_VARS INCLUDE_INSTALL_DIR)
 write_basic_package_version_file(
   "${CMAKE_CURRENT_BINARY_DIR}/LatAnalyzeConfigVersion.cmake"
   VERSION "${PROJECT_VERSION}"

lib/Config.cmake.in

@@ -25,4 +25,6 @@ endforeach()
 
 include("${CMAKE_CURRENT_LIST_DIR}/LatAnalyzeTargets.cmake")
 
+set(@PROJECT_NAME@_INCLUDE_DIRS "@PACKAGE_INCLUDE_INSTALL_DIR@")
+
 check_required_components(LatAnalyze)

lib/LatAnalyze/Core/Plot.cpp

@@ -112,20 +112,28 @@ PlotHeadCommand::PlotHeadCommand(const string &command)
 }
 
 // PlotData constructor ////////////////////////////////////////////////////////
-PlotData::PlotData(const DMatSample &x, const DMatSample &y, const bool abs)
+PlotData::PlotData(const DVecPair &x, const DVecPair &y, const bool abs)
 {
-    if (x[central].rows() != y[central].rows())
+    if (x.first.rows() != y.first.rows())
     {
         LATAN_ERROR(Size, "x and y vectors do not have the same size");
     }
+    if (x.first.rows() != x.second.rows())
+    {
+        LATAN_ERROR(Size, "x and error vectors do not have the same size");
+    }
+    if (y.first.rows() != y.second.rows())
+    {
+        LATAN_ERROR(Size, "y and error vectors do not have the same size");
+    }
 
-    DMat d(x[central].rows(), 4);
+    DMat d(x.first.rows(), 4);
     string usingCmd, tmpFileName;
 
-    d.col(0)    = x[central].col(0);
+    d.col(0)    = x.first.col(0);
-    d.col(2)    = y[central].col(0);
+    d.col(2)    = y.first.col(0);
-    d.col(1)    = x.variance().cwiseSqrt().col(0);
+    d.col(1)    = x.second.col(0);
-    d.col(3)    = y.variance().cwiseSqrt().col(0);
+    d.col(3)    = y.second.col(0);
     tmpFileName = dumpToTmpFile(d);
     pushTmpFile(tmpFileName);
     if (!abs)
@@ -138,19 +146,23 @@ PlotData::PlotData(const DMatSample &x, const DMatSample &y, const bool abs)
     }
 }
 
-PlotData::PlotData(const DVec &x, const DMatSample &y, const bool abs)
+PlotData::PlotData(const DVec &x, const DVecPair &y, const bool abs)
 {
-    if (x.rows() != y[central].rows())
+    if (x.rows() != y.first.rows())
     {
-        LATAN_ERROR(Size, "x and y vector does not have the same size");
+        LATAN_ERROR(Size, "x and y vectors do not have the same size");
+    }
+    if (y.first.rows() != y.second.rows())
+    {
+        LATAN_ERROR(Size, "y and error vectors do not have the same size");
     }
 
     DMat d(x.rows(), 3);
     string usingCmd, tmpFileName;
 
     d.col(0)    = x;
-    d.col(1)    = y[central].col(0);
+    d.col(1)    = y.first.col(0);
-    d.col(2)    = y.variance().cwiseSqrt().col(0);
+    d.col(2)    = y.second.col(0);
     tmpFileName = dumpToTmpFile(d);
     pushTmpFile(tmpFileName);
     if (!abs)
@@ -163,19 +175,23 @@ PlotData::PlotData(const DVec &x, const DMatSample &y, const bool abs)
     }
 }
 
-PlotData::PlotData(const DMatSample &x, const DVec &y, const bool abs)
+PlotData::PlotData(const DVecPair &x, const DVec &y, const bool abs)
 {
-    if (x[central].rows() != y.rows())
+    if (x.first.rows() != y.rows())
     {
         LATAN_ERROR(Size, "x and y vectors do not have the same size");
     }
+    if (x.first.rows() != x.second.rows())
+    {
+        LATAN_ERROR(Size, "x and error vectors do not have the same size");
+    }
 
-    DMat d(x[central].rows(), 3), xerr, yerr;
+    DMat d(x.first.rows(), 3), xerr, yerr;
     string usingCmd, tmpFileName;
 
-    d.col(0)    = x[central].col(0);
+    d.col(0)    = x.first.col(0);
     d.col(2)    = y;
-    d.col(1)    = x.variance().cwiseSqrt().col(0);
+    d.col(1)    = x.second.col(0);
     tmpFileName = dumpToTmpFile(d);
     pushTmpFile(tmpFileName);
     if (!abs)
@@ -188,6 +204,19 @@ PlotData::PlotData(const DMatSample &x, const DVec &y, const bool abs)
     }
 }
 
+PlotData::PlotData(const DMatSample &x, const DMatSample &y, const bool abs)
+: PlotData(DVecPair(x[central], x.variance().cwiseSqrt()), 
+           DVecPair(y[central], y.variance().cwiseSqrt()), abs)
+{}
+
+PlotData::PlotData(const DVec &x, const DMatSample &y, const bool abs)
+: PlotData(x, DVecPair(y[central], y.variance().cwiseSqrt()), abs)
+{}
+
+PlotData::PlotData(const DMatSample &x, const DVec &y, const bool abs)
+: PlotData(DVecPair(x[central], x.variance().cwiseSqrt()), y, abs)
+{}
+
 PlotData::PlotData(const XYStatData &data, const Index i, const Index j, const bool abs)
 {
     string usingCmd, tmpFileName;
@@ -913,6 +942,7 @@ ostream & Latan::operator<<(ostream &out, const Plot &plot)
     if (!plot.options_.terminal.empty())
     {
         out << "set term " << plot.options_.terminal << endl;
+        out << "set pointintervalbox 0" << endl;
     }
     if (!plot.options_.output.empty())
     {

lib/LatAnalyze/Core/Plot.hpp

@@ -87,8 +87,13 @@ public:
 
 class PlotData: public PlotObject
 {
+public:
+    typedef std::pair<DVec, DVec> DVecPair;
 public:
     // constructor
+    PlotData(const DVecPair   &x, const DVecPair   &y, const bool abs = false);
+    PlotData(const DVec       &x, const DVecPair   &y, const bool abs = false);
+    PlotData(const DVecPair   &x, const DVec       &y, const bool abs = false);
     PlotData(const DMatSample &x, const DMatSample &y, const bool abs = false);
     PlotData(const DVec       &x, const DMatSample &y, const bool abs = false);
     PlotData(const DMatSample &x, const DVec       &y, const bool abs = false);

lib/LatAnalyze/Physics/DataFilter.cpp

@@ -66,18 +66,18 @@ void DataFilter::operator()(DMat &out, const DMat &in)
  ******************************************************************************/
 // constructor ////////////////////////////////////////////////////////////////
 LaplaceDataFilter::LaplaceDataFilter(const bool downsample)
-: DataFilter({1., -2. , 1.}, downsample)
+: DataFilter({-1., 2. , -1.}, downsample)
 {}
 
 // filtering //////////////////////////////////////////////////////////////////
 void LaplaceDataFilter::operator()(DVec &out, const DVec &in, const double lambda)
 {
-    filter_[1] = -2. - lambda;
+    filter_[1] = 2. + Math::pow<2>(lambda);
     DataFilter::operator()(out, in);
 }
 
 void LaplaceDataFilter::operator()(DMat &out, const DMat &in, const double lambda)
 {
-    filter_[1] = -2. - lambda;
+    filter_[1] = 2. + Math::pow<2>(lambda);
     DataFilter::operator()(out, in);
 }

lib/LatAnalyze/Physics/DataFilter.hpp

@@ -70,7 +70,7 @@ public:
     template <typename MatType, Index o>
     double optimiseFunction(const StatArray<MatType, o> &data, 
                             ObjectiveFunction<MatType, o> &fn,
-                            Minimizer &min, const unsigned int nPass = 3);
+                            Minimizer &min);
 };
 
 /******************************************************************************
@@ -104,8 +104,7 @@ void LaplaceDataFilter::operator()(StatArray<MatType, o> &out,
 template <typename MatType, Index o>
 double LaplaceDataFilter::optimiseFunction(const StatArray<MatType, o> &data, 
                                            ObjectiveFunction<MatType, o> &fn, 
-                                           Minimizer &min,
+                                           Minimizer &min)
-                                           const unsigned int nPass)
 {
     StatArray<MatType, o> fdata(data.size());
     DVec init(1);